javascript - Function to refresh date every second eventually crashes Chrome -


i have few functions use date , time , push elements in dom. appears working great until after few minutes script drains chrome of memory , crashes page. here code think affecting problem:

'use strict';    // ///////////////////////////// initial /////////////////////////////////// //  function leading_0( num ) {    if( num < 10 ) {      num = '0' + num;    }        return num;  }    // ////////////////////////////// dates //////////////////////////////////// //    function getcurrenttime( date ) {  // time / / / / / / / / / / / / / / / / / //    var hours = date.gethours(),        minutes = date.getminutes(),        seconds = date.getseconds(),        suffix = hours >= 12 ? 'pm' : 'am',        fulltime;      hours = hours % 12;      if( hours === 0 ){      hours = 12;    }      minutes = leading_0( minutes );    seconds = leading_0( seconds );    fulltime = hours + ':' + minutes + ':' + seconds + ' ' + suffix;      return fulltime;  }  // \\/ / / / / / / / / / / / / / / time / / / / / / / / / / / / / / / / / //    function getyear( date ) {  /// / / / year / / / / / / / / / / / / / / / / / //    var year = date.getfullyear();      return year;  }  // \\/ / / / / / / / / / / / / / / year / / / / / / / / / / / / / / / / / //    function getmonthday( date ) {  /// month day / / / / / / / / / / / / / / / ///    var day = date.getdate();      return day;  }  // \\/ / / / / / / / / / / / / / month day / / / / / / / / / / / / / / / ///    function getmonth( date ) {  // / / / month / / / / / / / / / / / / / / / / ///    var months = [      'january', 'feburary', 'march',      'april', 'may', 'june',      'july', 'august', 'september',      'october', 'november', 'december'    ],    month = months[ date.getmonth() ];      return month;  }  // \\/ / / / / / / / / / / / / / / month / / / / / / / / / / / / / / / / ///    function getwkday( date ) {  /// / / week day / / / / / / / / / / / / / / / ///    var weekdays = [       'sunday', 'monday',       'tueday', 'wednesday',       'thursday', 'friday',       'saturday'     ],    wkday = weekdays[ date.getday() ];      return wkday;  }  // \\ / / / / / / / / / / / / / / week day / / / / / / / / / / / / / / / ///    function callbysec( func ) {    setinterval( func, 1000 );  }    function pushdate(){  /// / / / / / push dates / / / / / / / / / / / / / / / //    var today = new date(),        wkday,        month,        day,        year,        time,        d = document;          wkday = getwkday( today );    month = getmonth( today );    day = getmonthday( today );    year = getyear( today );    time = getcurrenttime( today );        d.getelementbyid( 'wkday' ).textcontent = wkday;    d.getelementbyid( 'month' ).textcontent = month;    d.getelementbyid( 'day' ).textcontent = day;    d.getelementbyid( 'year' ).textcontent = year;    d.getelementbyid( 'time' ).textcontent = time;        callbysec( pushdate );  }  // \\/ / / / / / / / / / / / / / push dates / / / / / / / / / / / / / / / //    // ////////////////////////////// start //////////////////////////////////// //  function start() {    pushdate();  }  start();
<p>    <span id="wkday"></span>,     <span id="month"></span> <span id="day"></span>,     <span id="year"></span> <b>|</b> <span id="time"></span>  </p>

is above code major memory hog? on page crashes chrome. there better way , same result?

take out line:

callbysec( pushdate );

at end of pushdate(). you're using setinterval() call function every second, don't need start timer again. result you're creating timer every second. after minute you're running function 60 times every second.

your code correct if callbysec used settimeout() rather setinterval().

then start() function should call callbysec:

'use strict';    function leading_0(num) {    if (num < 10) {      num = '0' + num;    }      return num;  }      function getcurrenttime(date) {    var hours = date.gethours(),      minutes = date.getminutes(),      seconds = date.getseconds(),      suffix = hours >= 12 ? 'pm' : 'am',      fulltime;      hours = hours % 12;      if (hours === 0) {      hours = 12;    }      minutes = leading_0(minutes);    seconds = leading_0(seconds);    fulltime = hours + ':' + minutes + ':' + seconds + ' ' + suffix;      return fulltime;  }     function getyear(date) {    var year = date.getfullyear();      return year;  }     function getmonthday(date) {     var day = date.getdate();      return day;  }     function getmonth(date) {     var months = [        'january', 'feburary', 'march',        'april', 'may', 'june',        'july', 'august', 'september',        'october', 'november', 'december'      ],      month = months[date.getmonth()];      return month;  }   function getwkday(date) {     var weekdays = [        'sunday', 'monday',        'tueday', 'wednesday',        'thursday', 'friday',        'saturday'      ],      wkday = weekdays[date.getday()];      return wkday;  }    function callbysec(func) {    setinterval(func, 1000);  }    function pushdate() {     var today = new date(),      wkday,      month,      day,      year,      time,      d = document;      wkday = getwkday(today);    month = getmonth(today);    day = getmonthday(today);    year = getyear(today);    time = getcurrenttime(today);      d.getelementbyid('wkday').textcontent = wkday;    d.getelementbyid('month').textcontent = month;    d.getelementbyid('day').textcontent = day;    d.getelementbyid('year').textcontent = year;    d.getelementbyid('time').textcontent = time;  }     function start() {    callbysec(pushdate);  }  start();
<p>    <span id="wkday"></span>,    <span id="month"></span> <span id="day"></span>,    <span id="year"></span> <b>|</b> <span id="time"></span>  </p>


Comments

Post a Comment

Popular posts from this blog

How to understand 2 main() functions after using uftrace to profile the C++ program? -

i trying uftrace profile following simple c++ program: #include <iostream> class { public: a() {std::cout << "a created" << std::endl;} ~a() {std::cout << "a destroyed" << std::endl;} }; int main() { a; return 0; } the profile result this: # uftrace a.out created destroyed # duration tid function 2.026 [ 4828] | __cxa_atexit(); [ 4828] | main() { [ 4828] | __static_initialization_and_destruction_0() { 89.397 [ 4828] | std::ios_base::init::init(); 0.768 [ 4828] | __cxa_atexit(); 93.029 [ 4828] | } /* __static_initialization_and_destruction_0 */ 94.425 [ 4828] | } /* main */ [ 4828] | main() { [ 4828] | a::a() { 11.104 [ 4828] | std::operator <<(); 10.825 [ 4828] | std::basic_ostream::operator <<(); 24.514 [ 4828] | } /* a::a */ [ 4828] | a::~a() { 0.978 [ 4828] | ...
Read more

c# - Update a combobox from a presenter (MVP) -

i using mvp in project, new in mvp. have 2 comboboxes. when select option in combobox, combobox should filled new data. this action in presenter. view 'view1' in presenter, , introduced combobox1 , combobox2 properties in 'view1', because need 'datasource', 'displaymember', 'valuemember' , 'refresh()' in method below. but, when using pattern, enough send property like public string combobox2 { { return combobox1.selectedvalue.tosstring(); } } into presenter not whole combobox. how can solve problem? public void onselectedindexchangedcombobox1() { if (view1.combobox1.selectedindex == -1) { return; } datatable dt = tools.getdatatable("a path"); var query = (from o in dt.asenumerable() o.field<string>("afield") == farmerview.combobox1.selectedvalue.tostring() orderby o.field<string>("anotherfield") select...
Read more

How to put a lock and transaction on table using spring 4 or above using jdbcTemplate and annotations like @Transactional? -

i trying put lock on table while writing on table , if happened in between roll-back . trying convert below code lock table test_g1 read; lock table test_g write; -- begin; start transaction; insert test_g1 values(143); insert test_g values(145); select * test_g1; select * test_g; rollback; select * test_g; unlock tables; how convert above code @transactional spring jdbctemplate code? @transactional(rollbackfor={dataaccessexception.class}) public void test(){ jdbctemplate.execute("insert test1 (id, nam) values (4, 'a')"); throw new dataaccessexception("error") { }; } here trying throw error, insert statement should rollback it's not happening . thanks edit-1 attaching code , doing in jdbcdaoimpl.java , mentioned problem comment above test() . app.java package com.cgiri.javabrains.spring4; import org.springframework.beans.factory.annotation.autowired; import org.springframework.context.applic...
Read more