c++ - swap function in quick sort gives wrong output -


swap function quick sort. gives wrong output. when use temporary variable gives correct output. here tester:

void swap(int &a,int &b){     a=a+b;     b=a-b;     a=a-b; }

this works fine though:

void swap(int &a,int &b){     int temp=a;     a=b;     b=a; }

i passing array elements function inside partition function of quick sort algorithm.

your code swap without 3rd variable looks ok. unfortunately, algorithm cannot applied swapping value itself, example:

void swap(int &a,int &b){   // &a == &b, value 123     a=a+b;                  // == b == 246     b=a-b;                  // == b == 0 (oops!)     a=a-b;                  // == b == 0  }

also, please note there's standard function swapping (std::swap) , code, if compiled without optimization, works slower usual swap (with 3rd variable) performs more memory operations. also, code may lead integer overflow or underflow undefined behavior standard , may or may not work expect. if add readability issue (the important thing) list, recommendation just don't use swap without 3rd variable.


Comments

Post a Comment

Popular posts from this blog

javascript - Knockout pushing observable and computed data to an observable array -

i trying push multiple data (firstname , lastname), along when compute firstname , lastname , try push data in same array thrown error. below code. viewmodel: var viewmodel = function () { var self = this; self.gameofthrones = ko.observablearray ([ {firstname: 'jon', lastname: 'snow'}, {firstname: 'robb', lastname: 'stark'} ]); self.firstname = ko.observable(''); self.lastname = ko.observable(''); (var i=0; i<self.gameofthrones().length; i++) { self.gameofthrones()[i].fullname = ko.computed (function () { return self.gameofthrones()[i].firstname+" "+self.gameofthrones()[i].lastname; }) }; $('#classic').click( function() { self.gameofthrones.push( {firstname: $('#fn').val(), lastname: $('#pr').val()} ); }); } ko.applybindings(new viewmodel()); html view: <form class="" action="index.html" method="post"...
Read more

'hasOwnProperty' in javascript -

i use obj.hasownproperty judge whether object has property, when replaced obj[prop] !== undefined , not normal implementation, ask, why behind method can not use it? object.hasownproperty(prop); object[prop] !== undefined; obj[prop] !== undefined wrong 2 reasons: you can explicitly set property undefined , obj[prop] = undefined; . obj.hasownproperty(prop) return true in case. obj[prop] follow prototype chain, return property that's inherited. obj.hasownproperty(prop) returns true if property exists directly in object, returns false inherited properties.
Read more

c# - Update a combobox from a presenter (MVP) -

i using mvp in project, new in mvp. have 2 comboboxes. when select option in combobox, combobox should filled new data. this action in presenter. view 'view1' in presenter, , introduced combobox1 , combobox2 properties in 'view1', because need 'datasource', 'displaymember', 'valuemember' , 'refresh()' in method below. but, when using pattern, enough send property like public string combobox2 { { return combobox1.selectedvalue.tosstring(); } } into presenter not whole combobox. how can solve problem? public void onselectedindexchangedcombobox1() { if (view1.combobox1.selectedindex == -1) { return; } datatable dt = tools.getdatatable("a path"); var query = (from o in dt.asenumerable() o.field<string>("afield") == farmerview.combobox1.selectedvalue.tostring() orderby o.field<string>("anotherfield") select...
Read more